feat!: Classical op params #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
approved these changes
Jul 9, 2024
| // Note: The order of the variants here is important. | ||
| // Serde will return the first matching variant when deserializing, | ||
| // so CopyBits and SetBits must come after other variants that | ||
| // define `values` and `n_i`. |
There was a problem hiding this comment.
Bit puzzled by this, does the serialization not include the name?
There was a problem hiding this comment.
The name is in Operation::type, but this field is not directly linked to it.
If type was a closed set we would be able to link classical and type more easily, but as it is now we just have a string field where some special values cause the classical enum to be of some type.
It's probably still possible to do something, but it'd be a big refactor of the Operation definition.
And to be pedantic, the schema does not link specific names with their required fields. It only lists a set of names for which classical must be defined. The Classical object itself is just a oneOf set of options.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
## 🤖 New release * `tket-json-rs`: 0.4.2 -> 0.5.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.5.0 (2024-07-09) ### Features - Handle legacy tk1 optype ([#54](#54)) - [**breaking**] Classical op params ([#56](#56)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
drive-by: Add missing
datafield to Operation (schema).drive-by: Remove
created_qubits/discarded_qubitsfrom the test files. Those fields are not in the schema.drive-by: Mark more structs as
non_exhaustive, so in the future a change like this does not have to be breaking.BREAKING CHANGE: Added
dataandclassicalfields toOperation. Marked some structs/enums as non_exhaustive.