ci: Test missing op definitions against pytket
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Adds the missing optypes listed in #36. Fixes #30. --------- Co-authored-by: Alec Edgington <[email protected]>
|
After merging #37 the new check succeeds :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an integration tests that checks whether all elements of
pytket.OpType.__members__are present in theOpTypeenum.Adds a CI check for this that runs on pull requests / merges as well as on a cron job every day to ensure that new pytket releases are always tested.
This test currently fails with the following message:
I'll open another PR with those implementations.
Ideally the cron job would also create an issue when the test fails, but I'll look into that another time.
Closes #31 .