feat!: non-locking python conversion calls #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`from_tket1` and `to_tket1` now receive the Global Interpreter Lock (GIL) as a parameter rather than adquiring it internally. The locking methods are kept as utility functions. BREAKING CHANGE: Renamed `SerialCircuit::to_tket1` to `to_tket1_with_gil`, and `_from_tket1` to `from_tket1_with_gil`.
ss2165
approved these changes
Nov 9, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
## 🤖 New release * `tket-json-rs`: 0.2.0 -> 0.3.0 (⚠️ API breaking changes) ###⚠️ `tket-json-rs` breaking changes ``` --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.24.2/src/lints/inherent_method_missing.ron Failed in: SerialCircuit::_from_tket1, previously in file /tmp/.tmpCcfyh4/tket-json-rs/src/pytket.rs:10 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.24.2/src/lints/method_parameter_count_changed.ron Failed in: tket_json_rs::circuit_json::SerialCircuit::to_tket1 now takes 2 parameters instead of 1, in /tmp/.tmpvYRSl5/tket-json-rs/src/pytket.rs:22 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.3.0 (2023-11-09) ### Features - [**breaking**] Non-locking python conversion calls ([#25](#25)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_tket1andto_tket1now receive the Global Interpreter Lock (GIL) as a parameter rather than adquiring it internally.This is more composable in cases where we want to reuse the GIL.
The locking methods are kept as utility functions.
BREAKING CHANGE: Renamed
SerialCircuit::to_tket1toto_tket1_with_gil, and_from_tket1tofrom_tket1_with_gil.