Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logo adapt to dark mode; add source code links to documentation #113

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

gamatos
Copy link
Collaborator

@gamatos gamatos commented Nov 8, 2023

  • Make logo adapt to dark mode (it currently partly blends into the dark background)
  • Add source code links to the API in the documentation. These links take the user directly to the range of lines where the function is defined in the source file in the GitHub repository.

@gamatos gamatos requested a review from cqc-melf November 8, 2023 14:15
@gamatos gamatos force-pushed the logo_dark_mode branch 2 times, most recently from f197253 to a2985fc Compare November 8, 2023 14:18
@gamatos
Copy link
Collaborator Author

gamatos commented Nov 8, 2023

Documentation generated by the CI action is all good ✅

@@ -62,3 +66,24 @@
"collapse_navigation": False,
"prev_next_buttons_location": "None",
}


def linkcode_resolve(domain, info):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say a few words for what this function is used for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! I'll add a comment explaining what it does

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@gamatos gamatos merged commit 3832018 into develop Nov 10, 2023
5 checks passed
@gamatos gamatos deleted the logo_dark_mode branch November 10, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants