Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests and handling of null bit list #212

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Fix integration tests and handling of null bit list #212

merged 3 commits into from
Aug 30, 2023

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Aug 30, 2023 •
edited
Loading

Fixes #200 .
Fixes #211 .

Integration tests run here: https://github.com/CQCL/pytket-quantinuum/actions/runs/6025777087 (all green).

@cqc-alec cqc-alec changed the title Bugfix/submit Fix integration tests and handling of null bit list Aug 30, 2023
@cqc-alec cqc-alec marked this pull request as ready for review August 30, 2023 13:59
@cqc-alec cqc-alec requested a review from yao-cqc as a code owner August 30, 2023 13:59
yao-cqc
yao-cqc approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@yao-cqc yao-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cqc-alec cqc-alec merged commit 9bd4229 into develop Aug 30, 2023
@cqc-alec cqc-alec deleted the bugfix/submit branch August 30, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-cqc yao-cqc yao-cqc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failures in integration tests Remote tests fail with: User does not belong to group
2 participants
@cqc-alec @yao-cqc