Overloaded get_compiled_circuit/s
#423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-melf
reviewed
Nov 26, 2024
| @@ -410,7 +410,34 @@ def default_compilation_pass_offline( | |||
| passlist.append(FullPeepholeOptimise()) | |||
| elif optimisation_level == 3: | |||
| passlist.append(RemoveBarriers()) | |||
| passlist.append(AutoRebase({OpType.CX, OpType.H, OpType.Rz})) | |||
| passlist.append( | |||
There was a problem hiding this comment.
Is this a relevant change, that should be in the changelog, too?
There was a problem hiding this comment.
I don't think we don't need to include this - all I've done is update the set of gates we AutoRebase to so that it exactly matches what GreedyPauliSimp accepts. We don't mention this rebase for the GreedyPauliSimp line of the changelog so I don't think it's worth explicitly pointing out.
| :rtype: Circuit | ||
| """ | ||
| return_circuit = circuit.copy() | ||
| if optimisation_level == 3 and circuit.n_gates_of_type(OpType.Barrier) > 0: |
There was a problem hiding this comment.
Why is this check not in the other function get_compiled_circuits ?
There was a problem hiding this comment.
get_compiled_circuits calls this method so the check is done implicitly
| :rtype: Circuit | ||
| """ | ||
| return_circuit = circuit.copy() | ||
| if optimisation_level == 3 and circuit.n_gates_of_type(OpType.Barrier) > 0: |
There was a problem hiding this comment.
same answer as for AerBackend
cqc-melf
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout wasn't being passed appropriately in the previous version. This PR overloads the
Backend.get_compiled_circuitandBackend.get_compiled_circuitsmethods to add atimeoutparameter, as withpytket-quantinuum, making sure users can modify it for using optimisation level 3.Checklist