-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimisation level 3 #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small comments
docs/changelog.md
Outdated
@@ -11,6 +11,7 @@ | |||
- Update default compilation to use `Qiskit` `SabreLayoutPassManager` as a `CustomPass`. | |||
- Fix handling of non-default registers when selecting bits in results. | |||
- The {py:func}`tk_to_qiskit` converter gives a warning if the input {py:class}`~pytket.circuit.Circuit` contains [implicit qubit permutations](https://docs.quantinuum.com/tket/user-guide/manual/manual_circuit.html#implicit-qubit-permutations). | |||
- Add new level 3 optimisation that uses `GreedyPauliSimp` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to 0.60.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
) | ||
return SequencePass( | ||
[ | ||
DecomposeBoxes(), | ||
FullPeepholeOptimise(), | ||
RemoveBarriers(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing the barriers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GreedyPauliSimp
doesn't support them - I'll update the documentation to make it clear that this optimisation level will remove them
setup.py
Outdated
@@ -46,7 +46,7 @@ | |||
packages=find_namespace_packages(include=["pytket.*"]), | |||
include_package_data=True, | |||
install_requires=[ | |||
"pytket >= 1.34.0", | |||
"pytket == 1.35.0rc2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could do 1.35.0 (please add that to the changelog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Add a new optimisation level to
pytket-qiskit
that usesGreedyPauliSimp
to optimise circuits.Checklist