Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported dynamic parameter #213

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

cqc-melf
Copy link
Collaborator

@cqc-melf cqc-melf commented Nov 23, 2023

Summary: ci check on develop are not working, see for example https://github.com/CQCL/pytket-qiskit/actions/runs/6967703011/job/18968998699

I was not able to find the dynamic parameter in the qiskit documentation or changelog. It is unclear to my why this is not working.

I would assume that this parameter is not supported any more, but that is just guessing.

It is unclear to my, why this parameter was submitted to the backend again in the past, any helpful comments / opinions on this?

(We should also update https://cqcl.github.io/tket/pytket/api/predicates.html#pytket.predicates.NoFastFeedforwardPredicate it does not explain what this is used for)

Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe this argument was being ignored previously and there is stricter checking now? The tests passed previously with the current versions of qiskit-ibm-runtime etc so perhaps it is a change in the backend.

@cqc-melf
Copy link
Collaborator Author

I have checked other versions, the problem is not related to the qiskit or the runtime update.

@cqc-melf cqc-melf merged commit 407a5f1 into develop Nov 23, 2023
7 checks passed
@cqc-melf cqc-melf deleted the fix/remove-dynamic-parameter branch March 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants