Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/support create #90

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Bugfix/support create #90

merged 2 commits into from
Mar 29, 2024

Conversation

PabloAndresCQ
Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ commented Mar 27, 2024 •
edited
Loading

Description

The tensor network converter TensorNetwork did not support the Create operation that explicitly initialises a qubit to state |0>. This PR adds a bugfix and tests for this.

Related issues

Bugfix for issue #88.

Checklist

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@PabloAndresCQ PabloAndresCQ requested a review from erinaldiq March 27, 2024 15:06
@PabloAndresCQ PabloAndresCQ mentioned this pull request Mar 27, 2024
Closed
erinaldiq
erinaldiq approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@erinaldiq erinaldiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pablo, I tested this after installing this branch on Perlmutter.
It does not error on my circuit anymore.
This is the only test I did though. I also looked at your test in q4_with_creates and it looks good to me.

@PabloAndresCQ PabloAndresCQ merged commit 25e591d into develop Mar 29, 2024
6 checks passed
@PabloAndresCQ PabloAndresCQ deleted the bugfix/support_create branch March 29, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinaldiq erinaldiq erinaldiq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloAndresCQ @erinaldiq