Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python support to 3.10, 3.11 and 3.12 #73

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Update python support to 3.10, 3.11 and 3.12 #73

merged 7 commits into from
Jan 17, 2024

Conversation

sjdilkes
Copy link
Contributor

This PR drops python 3.9 support and adds python 3.12, in line with pytket doing so.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@sjdilkes sjdilkes marked this pull request as ready for review January 16, 2024 14:42
PabloAndresCQ
PabloAndresCQ approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good! I have run the tests again and they work alright. Feel free to merge!

@sjdilkes sjdilkes merged commit 71f0266 into develop Jan 17, 2024
6 checks passed
@sjdilkes sjdilkes deleted the feature/python-3.12 branch January 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloAndresCQ PabloAndresCQ PabloAndresCQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjdilkes @PabloAndresCQ