Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/mps arguments #35

Merged
merged 20 commits into from
Oct 26, 2023
Merged

Refactor/mps arguments #35

merged 20 commits into from
Oct 26, 2023

Conversation

PabloAndresCQ
Copy link
Collaborator

  • Added a ConfigMPS object where all of the parameters for MPS simulation are set.
  • Added a value_of_zero parameter.
  • Changed the behaviour of the "exact" simulation of 2q gates to take into account the value_of_zero.

PabloAndresCQ and others added 13 commits September 25, 2023 15:32
@PabloAndresCQ
Copy link
Collaborator Author

Currently the diff is a mess because I have merged with feature/mps_logger. When that one is merged with develop, I'll fix the diff.

Also, I'll update the Jupyter notebook to work with this new refactor.

@PabloAndresCQ PabloAndresCQ requested a review from yapolyak October 3, 2023 23:01
yapolyak
yapolyak suggested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@yapolyak yapolyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple of things to be fixed.

@PabloAndresCQ PabloAndresCQ merged commit 8327268 into develop Oct 26, 2023
6 checks passed
@PabloAndresCQ PabloAndresCQ deleted the refactor/mps_arguments branch October 26, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yapolyak yapolyak yapolyak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloAndresCQ @yapolyak