[bugfix] GPU properties not displayed by logger #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.debug("GPU-minor:", device_props["minor"]) | ||
| logger.debug("========================") | ||
| logger.info("===== device info ======") | ||
| logger.info("GPU-name: " + device_props["name"].decode()) |
There was a problem hiding this comment.
Purely nitpicking: why not opt for fstrings?
E.g.
logger.info(f"GPU-name: {device_props['name'].decode()}")
There was a problem hiding this comment.
I went for that in the first commit, and mypy did not know how to parse that for some reason, so I went for this other approach 🤷
|
Could a test be written to verify that a call to this function doesn't produce an exception? |
jake-arkinstall
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue below. The issue has a code snippet to reproduce the error (and see what the fix did).
Related issues
Solves issue #143
Checklist