Merge pull request #33 from CQCL/bugfix/flush_and_canonical

Bugfix/flush and canonical
CQCL · Sep 27, 2023 · a15c2c8 · a15c2c8
2 parents 63980ae + 527c39d
commit a15c2c8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/pytket/extensions/cutensornet/mps/mps.py b/pytket/extensions/cutensornet/mps/mps.py
@@ -372,9 +372,9 @@ def canonicalise_tensor(self, pos: int, form: DirectionMPS) -> None:
 
         # Update self.tensors
         self.tensors[pos] = Q
-        self.tensors[pos].canonical_form = form
+        self.canonical_form[pos] = form  # type: ignore
         self.tensors[next_pos] = result
-        self.tensors[next_pos].canonical_form = None
+        self.canonical_form[next_pos] = None
 
     def vdot(self, other: MPS) -> complex:
         """Obtain the inner product of the two MPS: ``<self|other>``.

diff --git a/pytket/extensions/cutensornet/mps/simulation.py b/pytket/extensions/cutensornet/mps/simulation.py
@@ -87,6 +87,9 @@ def simulate(
     for g in sorted_gates:
         mps.apply_gate(g)
 
+    # Apply the batched operations that are left (if any)
+    mps._flush()
+
     # Apply the circuit's phase to the leftmost tensor (any would work)
     mps.tensors[0] = mps.tensors[0] * np.exp(1j * np.pi * circuit.phase)
 

diff --git a/tests/test_mps.py b/tests/test_mps.py
@@ -333,7 +333,7 @@ def test_circ_approx_explicit(circuit: Circuit) -> None:
 
         # Check for MPSxMPO
         mps_mpo = simulate(libhandle, circuit, ContractionAlg.MPSxMPO, chi=8)
-        assert np.isclose(mps_mpo.fidelity, 0.06, atol=1e-2)
+        assert np.isclose(mps_mpo.fidelity, 0.04, atol=1e-2)
         assert mps_mpo.is_valid()
         assert np.isclose(mps_mpo.vdot(mps_mpo), 1.0, atol=mps_mpo._atol)