ci: Move file change filter definitions to a file #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croyzor
reviewed
May 1, 2024
| - 'hugr-py/**' | ||
| - 'pyproject.toml' | ||
| - 'specification/schema/**' | ||
| filters: .github/change-filters.yml |
There was a problem hiding this comment.
Do we not need to specify whether we want the rust filter or the python filter here?
There was a problem hiding this comment.
It computes both, an we use the one we need. It's not an expensive operation so it doesn't change much.
There was a problem hiding this comment.
So after this PR, we'll run both ci-py and ci-rs when relevant python or rust files are changed, but we wont run either when other files change. Is that right?
There was a problem hiding this comment.
Yes, that's the same behaviour we have already.
The other job steps check for
if: ${{ needs.changes.outputs.python == 'true' }}or
if: ${{ needs.changes.outputs.rust == 'true' }}to see if they should run or be skipped
croyzor
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup PR. Centralises the file filter used by
dorny/paths-filterwhen detecting changes in a single.yml.