Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore serialisation tests when using miri #975

Merged
merged 1 commit into from
Apr 26, 2024
Merged

test: ignore serialisation tests when using miri #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hugr/src/hugr/serialize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,9 @@ impl TryFrom<SerHugrV1> for Hugr {
}

#[cfg(test)]
#[cfg_attr(miri, ignore = "miri does not support 'life before main'")]
// Miri doesn't run the extension registration required by `typetag` for
// registering `CustomConst`s. https://github.com/rust-lang/miri/issues/450
pub mod test {

use super::*;
Expand Down Expand Up @@ -547,9 +550,6 @@ pub mod test {
}

#[test]
#[cfg_attr(miri, ignore = "Extension ops cannot be used with miri.")]
// Miri doesn't run the extension registration required by `typetag` for registering `CustomConst`s.
// https://github.com/rust-lang/miri/issues/450
fn constants_roundtrip() -> Result<(), Box<dyn std::error::Error>> {
let mut builder = DFGBuilder::new(FunctionType::new(vec![], vec![FLOAT64_TYPE])).unwrap();
let w = builder.add_load_value(ConstF64::new(0.5));
Expand Down
1 change: 1 addition & 0 deletions hugr/src/hugr/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ impl<'a, 'b> ValidationContext<'a, 'b> {
// in-tree schema. For now, our serialized hugr does not match the
// schema. When this is fixed we should pass true below.
#[cfg(test)]
#[cfg_attr(miri, ignore = "miri does not support 'life before main'")]
crate::hugr::serialize::test::check_hugr_roundtrip(self.hugr, false);

Ok(())
Expand Down