Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: CustomConst is not restricted to being CustomType #878

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Mar 13, 2024

No description provided.

@doug-q doug-q force-pushed the feat/anytype-consts branch 3 times, most recently from 0a12496 to 740680e Compare March 13, 2024 15:05
@doug-q
Copy link
Collaborator Author

doug-q commented Mar 13, 2024

Addresses #877

@doug-q doug-q requested review from aborgna-q and croyzor and removed request for croyzor March 13, 2024 15:06
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.49%. Comparing base (6ff6c01) to head (7da5cc5).

Files Patch % Lines
...um-hugr/src/std_extensions/arithmetic/int_types.rs 50.00% 2 Missing ⚠️
quantinuum-hugr/src/ops/constant.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   85.48%   85.49%           
=======================================
  Files          78       78           
  Lines       14450    14456    +6     
  Branches    14450    14456    +6     
=======================================
+ Hits        12353    12359    +6     
  Misses       1460     1460           
  Partials      637      637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@doug-q doug-q added this pull request to the merge queue Mar 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2024
@doug-q doug-q force-pushed the feat/anytype-consts branch from 740680e to 7da5cc5 Compare March 14, 2024 10:39
@doug-q doug-q added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit d5294ad Mar 14, 2024
10 checks passed
@doug-q doug-q deleted the feat/anytype-consts branch March 14, 2024 13:21
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants