feat: Make various data publicly accessible #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 85.59% 85.48% -0.12%
==========================================
Files 78 78
Lines 14432 14450 +18
Branches 14432 14450 +18
==========================================
- Hits 12353 12352 -1
- Misses 1442 1460 +18
- Partials 637 638 +1 ☔ View full report in Codecov by Sentry. |
doug-q
force-pushed
the
feat/misc-public
branch
from
df0a3f3 to
815a8c8
Compare
doug-q
commented
Mar 12, 2024
| @@ -246,6 +251,12 @@ impl TypeArg { | |||
| } | |||
| } | |||
|
|
|||
| impl TypeArgVariable { | |||
There was a problem hiding this comment.
There's no docstring here, why isn't CI catching this?
There was a problem hiding this comment.
Uh, seems I missed setting lints.workspace = true in the package's Cargo.toml when I created the workspace...
I can fix it in a separate PR, or you can add
[lints]
workspace = truein quantinuum-hugr/Cargo.toml.
Good catch!
aborgna-q
approved these changes
Mar 12, 2024
doug-q
force-pushed
the
feat/misc-public
branch
from
815a8c8 to
f6e3d7f
Compare
Closed
Merged
doug-q
added a commit
to doug-q/hugr
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.