Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Default more functions to using open_extensions #619

Closed
wants to merge 3 commits into from

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented Oct 23, 2023

A combined version of #616 #617 and #618

@croyzor croyzor requested a review from acl-cqc October 23, 2023 14:18
Copy link
Contributor

@acl-cqc acl-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but I've been prodding around here myself too and discovering how much of a maze these various methods are :-(. Does this make add_op_with_parent also use open_extensions?

@acl-cqc
Copy link
Contributor

acl-cqc commented Oct 23, 2023

Does this make add_op_with_parent also use open_extensions?

No, it doesn't :(. So I think it's non-obvious, indeed counterintuitive, that which add_op/add_node function you use, changes what Option<ExtensionSet> you get. I think we should probably focus on figuring out why using open_extensions everywhere doesn't work.

@croyzor
Copy link
Contributor Author

croyzor commented Oct 23, 2023

add_op_with_parent still uses pure, or there'd be no reason to change the implementation of any_block_builder.
Still need to investigate what needs done to update add_op_with_parent, unfortunately

@acl-cqc
Copy link
Contributor

acl-cqc commented Oct 31, 2023

Superceded by #622

@acl-cqc acl-cqc closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants