fix: Automatically add resource req for custom ops #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #388
This fix is blocked by extension inference.
The failing test in
builder::circuit::test::with_nonlinear_and_outputs
constructs this diagram:Where
MissingRsrc.MyOp
now requiresMissingRsrc
. The output node has that extension ininput_resources
, but the rest of the operations in the region need to define it too. (And I think we'll require a lift node for qubit 1?)