Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Change "serialise" etc to "serialize" etc. #1251

Merged
merged 1 commit into from
Jul 2, 2024
Merged

style: Change "serialise" etc to "serialize" etc. #1251

merged 1 commit into from
Jul 2, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Jul 2, 2024

Did: git grep -l -i 'serialis' | xargs sed -i 's/erialis/erializ/g'

The "-ize" spelling is already used much more often, so let's be consistent.

@cqc-alec
style: Change "serialise" etc to "serialize" etc.
e68d1c0 
Did: git grep -l -i 'serialis' | xargs sed -i 's/erialis/erializ/g'
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (3e4ac18) to head (e68d1c0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1251   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files         102      102           
  Lines       19108    19108           
  Branches    17015    17015           
=======================================
  Hits        16622    16622           
  Misses       1709     1709           
  Partials      777      777
Flag Coverage Δ
python 91.16% <ø> (ø)
rust 86.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cqc-alec cqc-alec marked this pull request as ready for review July 2, 2024 08:24
@cqc-alec cqc-alec requested review from aborgna-q, ss2165 and a team as code owners July 2, 2024 08:24
aborgna-q
aborgna-q approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
It looks like we only used UK spelling on docs. Was all the code US-style?

We should maybe decide to use either UK or US spelling everywhere, and add it to DEVELOPMENT.md.

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented Jul 2, 2024

👍 It looks like we only used UK spelling on docs. Was all the code US-style?

We should maybe decide to use either UK or US spelling everywhere, and add it to DEVELOPMENT.md.

It's not quite as simple as US/UK style: there are different UK styles. See for example https://academic.oup.com/pages/authoring/books/preparing-your-manuscript/house-style#oup .

I wouldn't be opposed to adopting (and documenting) a house style, such as the OUP one, but this should perhaps be a larger conversation between software projects.

@cqc-alec cqc-alec added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 8f08b8c Jul 2, 2024
22 checks passed
@cqc-alec cqc-alec deleted the ae/ize branch July 2, 2024 09:23
@hugrbot hugrbot mentioned this pull request Jul 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2024
@hugrbot
chore: release (#1248)
1baa697 
## 🤖 New release
* `hugr`: 0.6.1 -> 0.7.0
* `hugr-core`: 0.3.1 -> 0.4.0
* `hugr-passes`: 0.3.0 -> 0.4.0
* `hugr-cli`: 0.1.2 -> 0.1.3

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.7.0 (2024-07-10)

### Bug Fixes

- Bring back input_extensions serialized field in rust NodeSer
([#1275](#1275))
- [**breaking**] `ops::Module` now empty struct rather than unit struct
([#1271](#1271))

### Features

- Add `force_order` pass.
([#1285](#1285))
- [**breaking**] `MakeOpDef` has new `extension` method.
([#1266](#1266))

### Refactor

- [**breaking**] Remove `Value::Tuple`
([#1255](#1255))
- [**breaking**] Rename `HugrView` function type methods + simplify
behaviour ([#1265](#1265))

### Styling

- Change "serialise" etc to "serialize" etc.
([#1251](#1251))

### Testing

- Add a test for [#1257](#1257)
([#1260](#1260))
</blockquote>

## `hugr-core`
<blockquote>

## 0.4.0 (2024-07-10)

### Bug Fixes

- Bring back input_extensions serialized field in rust NodeSer
([#1275](#1275))
- [**breaking**] `ops::Module` now empty struct rather than unit struct
([#1271](#1271))

### Features

- [**breaking**] `MakeOpDef` has new `extension` method.
([#1266](#1266))

### Refactor

- [**breaking**] Remove `Value::Tuple`
([#1255](#1255))
- [**breaking**] Rename `HugrView` function type methods + simplify
behaviour ([#1265](#1265))

### Styling

- Change "serialise" etc to "serialize" etc.
([#1251](#1251))

### Testing

- Add a test for [#1257](#1257)
([#1260](#1260))
</blockquote>

## `hugr-passes`
<blockquote>

## 0.4.0 (2024-07-10)

### Features

- Add `force_order` pass.
([#1285](#1285))

### Refactor

- [**breaking**] Remove `Value::Tuple`
([#1255](#1255))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.1.3 (2024-07-10)

### Styling

- Change "serialise" etc to "serialize" etc.
([#1251](#1251))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
This was referenced Jul 11, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 16, 2024
@hugrbot
chore: release (#1305)
fa42476 
## 🤖 New release
* `hugr`: 0.7.0 -> 0.8.0
* `hugr-core`: 0.4.0 -> 0.5.0
* `hugr-passes`: 0.4.0 -> 0.5.0
* `hugr-cli`: 0.1.3 -> 0.1.4

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.8.0 (2024-07-16)

### Bug Fixes

- [**breaking**] Force_order failing on Const nodes, add arg to rank.
([#1300](#1300))
- NonConvex error on SiblingSubgraph::from_nodes with multiports
([#1295](#1295))
- [**breaking**] Ops require their own extension
([#1226](#1226))

### Documentation

- Attempt to correct force_order docs
([#1299](#1299))

### Features

- Make `DataflowOpTrait` public
([#1283](#1283))
- Make op members consistently public
([#1274](#1274))

### Refactor

- [**breaking**] Rename builder helpers: ft1->endo_ft, ft2->inout_ft
([#1297](#1297))
</blockquote>

## `hugr-core`
<blockquote>

## 0.5.0 (2024-07-16)

### Bug Fixes

- NonConvex error on SiblingSubgraph::from_nodes with multiports
([#1295](#1295))
- [**breaking**] Ops require their own extension
([#1226](#1226))

### Features

- Make `DataflowOpTrait` public
([#1283](#1283))
- Make op members consistently public
([#1274](#1274))

### Refactor

- [**breaking**] Rename builder helpers: ft1->endo_ft, ft2->inout_ft
([#1297](#1297))
</blockquote>

## `hugr-passes`
<blockquote>

## 0.5.0 (2024-07-16)

### Bug Fixes

- [**breaking**] Ops require their own extension
([#1226](#1226))
- [**breaking**] Force_order failing on Const nodes, add arg to rank.
([#1300](#1300))

### Documentation

- Attempt to correct force_order docs
([#1299](#1299))

### Refactor

- [**breaking**] Rename builder helpers: ft1->endo_ft, ft2->inout_ft
([#1297](#1297))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.1.3 (2024-07-10)

### Styling

- Change "serialise" etc to "serialize" etc.
([#1251](#1251))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
@hugrbot hugrbot mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborgna-q aborgna-q aborgna-q approved these changes

@ss2165 ss2165 ss2165 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cqc-alec @ss2165 @aborgna-q