Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanups from writing docstring #1232

Merged
merged 7 commits into from
Jun 28, 2024
Merged

refactor: cleanups from writing docstring #1232

merged 7 commits into from
Jun 28, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jun 27, 2024

go commit by commit
mostly things like making methods/classes internal

@ss2165 ss2165 requested a review from a team as a code owner June 27, 2024 16:59
@ss2165 ss2165 requested review from acl-cqc and aborgna-q and removed request for acl-cqc June 27, 2024 16:59
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.07339% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (2b05771) to head (22f5f91).
Report is 1 commits behind head on main.

❗ Current head 22f5f91 differs from pull request most recent head 68c5e8b

Please upload reports for the commit 68c5e8b to get more accurate results.

Files Patch % Lines
hugr-py/src/hugr/ops.py 87.00% 13 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1232   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files         100      100           
  Lines       19021    19025    +4     
  Branches    17040    17040           
=======================================
+ Hits        16547    16551    +4     
  Misses       1696     1696           
  Partials      778      778
Flag Coverage Δ
python 91.48% <88.07%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aborgna-q
aborgna-q approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍

hugr-py/src/hugr/val.py

def to_serial(self) -> sops.TupleValue:
def to_serial(self) -> sops.TupleValue: # type: ignore[override]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why the ignore is needed?
It seems straightforward code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sops.TupleValue isn't an instance of sops.SumValue so mypy doesn't like the override of Sum.to_serial

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add comment

@ss2165 ss2165 enabled auto-merge June 28, 2024 08:45
@ss2165 ss2165 added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 80b8a85 Jun 28, 2024
18 checks passed
@ss2165 ss2165 deleted the ss/docs-refactors branch June 28, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborgna-q aborgna-q aborgna-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ss2165 @aborgna-q