Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hugr-py): remove module underscores #1230

Merged
merged 3 commits into from
Jun 27, 2024
Merged

refactor(hugr-py): remove module underscores #1230

merged 3 commits into from
Jun 27, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jun 27, 2024

and other minor refactors to set up docstrings (pulled out from larger PR to make easier merges)

let's try and not do a release between this and the docstring PR merge

@ss2165 ss2165 requested a review from a team as a code owner June 27, 2024 08:45
@ss2165 ss2165 requested a review from mark-koch June 27, 2024 08:45
@ss2165 ss2165 changed the title refactor: remove module underscores refactor(hugr-py): remove module underscores Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 86.28571% with 24 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (c21753d) to head (24319a7).

Files Patch % Lines
hugr-py/src/hugr/serialization/tys.py 75.92% 13 Missing ⚠️
hugr-py/src/hugr/serialization/ops.py 90.90% 7 Missing ⚠️
hugr-py/src/hugr/dfg.py 84.61% 2 Missing ⚠️
hugr-py/src/hugr/ops.py 83.33% 1 Missing ⚠️
hugr-py/src/hugr/val.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1230   +/-   ##
=======================================
  Coverage   86.98%   86.99%           
=======================================
  Files         100      100           
  Lines       19023    19021    -2     
  Branches    17040    17040           
=======================================
- Hits        16548    16547    -1     
+ Misses       1697     1696    -1     
  Partials      778      778           
Flag Coverage Δ
python 91.46% <86.28%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 enabled auto-merge June 27, 2024 09:09
@ss2165 ss2165 added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 2b05771 Jun 27, 2024
22 checks passed
@ss2165 ss2165 deleted the ss/no-unders branch June 27, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants