feat(hugr-sexpr): Add s-expression library. #1208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
- Coverage 87.03% 86.98% -0.06%
==========================================
Files 100 110 +10
Lines 18918 19751 +833
Branches 16935 17768 +833
==========================================
+ Hits 16466 17180 +714
- Misses 1676 1775 +99
- Partials 776 796 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zrho
force-pushed
the
feat/sexpr
branch
4 times, most recently
from
22f62a0 to
6275ba7
Compare
aborgna-q
reviewed
Jun 24, 2024
- Parse s-expressions - Pretty print s-expressions - Proc macros for converting between user types and s-expressions
This was not caught by the proptest before since the `Arbitrary` instance for `f64` does not generate these values. The proptest has been updated accordingly.
|
As a general purpose s-expression crate this probably does not belong in this repository after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
hugr-sexprlibrary for s-expressions.(This commit also updates the devenv lock file to the newest version, since on the
mainbranch version the Rust toolchain fails to work on my machine.)