Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hugr-py): common up a null check #1205

Merged
merged 1 commit into from
Jun 18, 2024
Merged

refactor(hugr-py): common up a null check #1205

merged 1 commit into from
Jun 18, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jun 18, 2024

avoids some bugs I kept making because of name similarities

avoids some bugs I kept making because of name similarities
@ss2165 ss2165 requested a review from a team as a code owner June 18, 2024 16:04
@ss2165 ss2165 requested a review from mark-koch June 18, 2024 16:04
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.64%. Comparing base (2bb079f) to head (4ede52c).

Files Patch % Lines
hugr-py/src/hugr/_ops.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   86.62%   86.64%   +0.01%     
==========================================
  Files          96       96              
  Lines       18253    18248       -5     
  Branches    16831    16831              
==========================================
- Hits        15812    15811       -1     
+ Misses       1667     1663       -4     
  Partials      774      774              
Flag Coverage Δ
python 89.13% <90.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 04ed329 Jun 18, 2024
20 checks passed
@ss2165 ss2165 deleted the refactor/incomplete branch June 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants