Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: datalog style constant folding solver skeleton #1157

Closed
wants to merge 12 commits into from
Closed

DRAFT: datalog style constant folding solver skeleton #1157

wants to merge 12 commits into from

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Jun 5, 2024

No description provided.

@hugrbot
Copy link
Collaborator

hugrbot commented Jun 5, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Your title should look like this. The scope field is optional.

<type>(<scope>): <description>

If the PR includes a breaking change, mark it with an exclamation mark:

<type>!: <description>

and include a "BREAKING CHANGE:" footer in the body of the pull request.

Details:

Unknown release type "DRAFT" found in pull request title "DRAFT: datalog style constant folding solver skeleton". 

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - ci
 - chore
 - revert

@doug-q doug-q force-pushed the doug/const-fold2 branch from 2ac4690 to 7173a7f Compare June 5, 2024 08:39
@aborgna-q aborgna-q changed the title wip feat: Constant folding solver Jun 5, 2024
@doug-q doug-q changed the title feat: Constant folding solver DRAFT: datalog style constant folding solver skeleton Jun 5, 2024
@doug-q doug-q mentioned this pull request Jul 22, 2024
Closed
@acl-cqc acl-cqc mentioned this pull request Aug 28, 2024
Merged
acl-cqc
acl-cqc reviewed Sep 11, 2024
View reviewed changes
hugr-passes/src/const_fold2/datalog/test.rs
assert_eq!(cond_r1, Value::false_val());
assert!(machine.read_out_wire_value(&c, cond_o2).is_none());

assert!(!machine.case_reachable(&c, case1.node()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doug-q why does this pass? The predicate to the conditional node is the input to the whole Hugr here, which has Sum type with three variants; nothing tells us what argument is passed into that input??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I get it - the arg_pv

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument is either variant 1 or variant 2 (containing variant 0 == false)

@acl-cqc acl-cqc mentioned this pull request Oct 21, 2024
Merged
@doug-q doug-q closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acl-cqc acl-cqc acl-cqc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doug-q @hugrbot @acl-cqc