Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move declarative.yaml example to the hugr-core crate #1131

Merged
merged 1 commit into from
May 29, 2024

Conversation

aborgna-q
Copy link
Collaborator

This is a file used for the hugr-core docs, so it should be included in that crate.

When trying to cargo publish, I got an error due to it not getting packaged.

error: couldn't read src/extension/../../../hugr/examples/extension/declarative.yaml: No such file or directory (os error 2)
  --> src/extension/declarative.rs:12:10
   |
12 | #![doc = include_str!("../../../hugr/examples/extension/declarative.yaml")]
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `include_str` (in Nightly builds, run with -Z macro-backtrace for more info)

@aborgna-q aborgna-q requested a review from doug-q May 29, 2024 13:36
@aborgna-q aborgna-q requested a review from a team as a code owner May 29, 2024 13:36
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand, cargo publish requires the crate to build "isolated" from the workspace?

Can we build "isolated" in CI?

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (d89b6f1) to head (bef51df).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files          91       91           
  Lines       18560    18560           
  Branches    18167    18167           
=======================================
  Hits        16107    16107           
  Misses       1606     1606           
  Partials      847      847           
Flag Coverage Δ
rust 86.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q
Copy link
Collaborator Author

Can we build "isolated" in CI?

It'd be nice! Can you open an issue?

@aborgna-q aborgna-q added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit f26b5be May 29, 2024
18 checks passed
@aborgna-q aborgna-q deleted the ab/move_declarative branch May 29, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants