Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use hugrbot token in CI #1110

Merged
merged 1 commit into from
May 24, 2024
Merged

ci: Use hugrbot token in CI #1110

merged 1 commit into from
May 24, 2024

Conversation

aborgna-q
Copy link
Collaborator

Replaces my own account's tokens with @hugrbot's.

Closes #1082

drive-by: Drop the unused jira-issue workflow.

@aborgna-q aborgna-q requested a review from a team as a code owner May 24, 2024 13:31
@aborgna-q aborgna-q requested review from zrho and doug-q and removed request for zrho May 24, 2024 13:31
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to delete RELEASE_PLEASE_PAT from settings when you merge.

@@ -118,6 +118,7 @@ jobs:
It looks like your proposed title indicates a breaking change. If that's the case,
please make sure to include a "BREAKING CHANGE:" footer in the body of the pull request
describing the breaking change and any migration instructions.
GITHUB_TOKEN: ${{ secrets.HUGRBOT_PAT }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these need a token when they didn't before? Does this give them narrower permissions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just so the comments are made by @hugrbot instead of @github-actions

@aborgna-q aborgna-q added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit b40392f May 24, 2024
14 checks passed
@aborgna-q aborgna-q deleted the ab/hugrbot branch May 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release-please's commits are created under @aborgna-q's user
2 participants