chore: Move dependencies to the workspace Cargo.toml #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
approved these changes
May 23, 2024
| num-rational = { version = "0.4.1", features = ["serde"] } | ||
| downcast-rs = "1.2.0" | ||
| serde = { version = "1.0", features = [ | ||
| # Rc used here for Extension, but unfortunately we must turn the feature on globally |
There was a problem hiding this comment.
This comment got lost, do we want to put it back?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 86.73% 86.78% +0.04%
==========================================
Files 90 90
Lines 18501 18501
Branches 18108 18108
==========================================
+ Hits 16047 16056 +9
+ Misses 1615 1606 -9
Partials 839 839
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated change generated by
cargo-autoinherit.This should simplify adding common dependencies on the new subcrates (#1100).