Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Move passes from
algorithms
into a separate crate #1100feat!: Move passes from
algorithms
into a separate crate #1100Changes from 26 commits
10f16f6
7b1e4f4
e94d594
4762a82
7bff248
880d4ab
0fd7211
04c4175
24f1df2
2a1ca98
9ee77bb
6971110
6ff82e8
95146e9
c6cddfd
9dab1a7
81cdc19
ffa7d9f
617e571
beb1d4d
c56a574
e099121
f27c71f
ad95736
e0ebb9f
1179886
be05699
8105f02
b1d9bd6
8840073
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the same major/minor version for all packages, to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case I can add
version
under[workspace.package]
in the top-levelCargo.toml
and use{workspace = true }
in both packages?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to have to make a new release of
hugr
whenever we do a new release ofhugr-passes
? This shouldn't be necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about having a matching minor number (0.x), even if the patch version varies.
But it may get desynchronised too, so I guess it's fine to leave it as 0.1.0.
The releases are done synchronously, but only for packages with changes.
See this PR for an example on how this looks.