Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix release-please not creating draft PRs #1093

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

This setting should make release-please create it's PRs as draft requests (to avoid annoying reviewers unnecessarily), but it doesn't seem to have worked #1092

The config json schema seemed to validate this as a global option, but it seems the value is not picked from there :/

This change moves the "use a draft PR" option to the project-specific section.

This setting should make release-please create it's PRs as draft requests (to avoid annoying reviewers unnecessarily), but it doesn't seem to have worked
#1092

The config json schema seemed to validate this as a global option, but it seems the value is not picked from there :/

This change moves the "use a draft PR" option to the project-specific section.
@aborgna-q aborgna-q requested a review from a team as a code owner May 21, 2024 09:39
@aborgna-q aborgna-q requested a review from croyzor May 21, 2024 09:39
@aborgna-q aborgna-q added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit b3d44c9 May 21, 2024
14 checks passed
@aborgna-q aborgna-q deleted the ab/release-draft-pr branch May 21, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants