-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: correct __version__ in hugr.py #1085
Conversation
32295fa
to
fd75380
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
- Coverage 86.60% 86.59% -0.01%
==========================================
Files 83 84 +1
Lines 17586 17589 +3
Branches 17586 17586
==========================================
+ Hits 15230 15232 +2
- Misses 1536 1537 +1
Partials 820 820
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
968d152
to
3a81836
Compare
3a81836
to
1fed9d4
Compare
This reverts commit 1fed9d4.
See #1086 for evidence that this works. We should close that PR when we merge this. I still need to work out what mypys problem is |
release-please-config.json
Outdated
"prerelease": false | ||
"prerelease": false, | ||
"extra-files": [{ | ||
"type": "generic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can get rid of this line and have release-please interpret init as a python file based on its extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed, have removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant the type
field, not the whole extra-files
bit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it seems to work... I'm a bit surpised!
A better demonstration of this working:
|
No description provided.