Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct __version__ in hugr.py #1085

Merged
merged 4 commits into from
May 21, 2024
Merged

chore: correct __version__ in hugr.py #1085

merged 4 commits into from
May 21, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented May 20, 2024

No description provided.

@doug-q doug-q requested a review from a team as a code owner May 20, 2024 14:55
@doug-q doug-q requested a review from croyzor May 20, 2024 14:55
@doug-q doug-q force-pushed the doug/hugr-py-v0.2.1-fix branch 2 times, most recently from 32295fa to fd75380 Compare May 20, 2024 14:59
@doug-q doug-q marked this pull request as draft May 20, 2024 14:59
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (bcffabd) to head (a37e7d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
- Coverage   86.60%   86.59%   -0.01%     
==========================================
  Files          83       84       +1     
  Lines       17586    17589       +3     
  Branches    17586    17586              
==========================================
+ Hits        15230    15232       +2     
- Misses       1536     1537       +1     
  Partials      820      820              
Flag Coverage Δ
python 66.66% <100.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doug-q doug-q force-pushed the doug/hugr-py-v0.2.1-fix branch 4 times, most recently from 968d152 to 3a81836 Compare May 20, 2024 15:11
@doug-q doug-q force-pushed the doug/hugr-py-v0.2.1-fix branch from 3a81836 to 1fed9d4 Compare May 20, 2024 15:12
@doug-q
Copy link
Collaborator Author

doug-q commented May 20, 2024

See #1086 for evidence that this works. We should close that PR when we merge this. I still need to work out what mypys problem is

@doug-q doug-q marked this pull request as ready for review May 20, 2024 15:19
"prerelease": false
"prerelease": false,
"extra-files": [{
"type": "generic",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can get rid of this line and have release-please interpret init as a python file based on its extension?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, have removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just meant the type field, not the whole extra-files bit!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it seems to work... I'm a bit surpised!

@doug-q
Copy link
Collaborator Author

doug-q commented May 21, 2024

A better demonstration of this working:

  • I spun a branch off this one doug/test-versioning and pushed a very important commit to it
  • I used the release-please cli to create a release pr: release-please release-pr --repo-url CQCL/hugr --target-branch 'doug/test-versioning' --token $(gh auth token)
  • I verified that chore(doug/test-versioning): release hugr-py 0.3.0 #1090 looks as expected

@doug-q doug-q added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 14ab387 May 21, 2024
17 checks passed
@doug-q doug-q deleted the doug/hugr-py-v0.2.1-fix branch May 21, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants