Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve times by splitting stable test runs #1072

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

Parallelises running stable tests with --no-features and -all-features.
This should reduce the critical path latency for the required checks.

I'm not doing this for the other compiler versions, as the delay is not that critical there and splitting workers pollutes the cache.

Closes #1064.

@aborgna-q aborgna-q requested a review from a team as a code owner May 17, 2024 11:22
@aborgna-q aborgna-q requested a review from croyzor May 17, 2024 11:22
Copy link
Contributor

@croyzor croyzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (d2087ce) to head (10f9a4b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   86.49%   86.59%   +0.09%     
==========================================
  Files          83       83              
  Lines       17547    17547              
  Branches    17547    17547              
==========================================
+ Hits        15178    15194      +16     
+ Misses       1548     1533      -15     
+ Partials      821      820       -1     
Flag Coverage Δ
rust 86.59% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q
Copy link
Collaborator Author

Looks roughly like a 30% improvement :)

@aborgna-q aborgna-q added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit e65b229 May 17, 2024
18 checks passed
@aborgna-q aborgna-q deleted the ab/ci-test-split branch May 17, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Consider running cargo test --all-features and cargo test --no-features` in parallel.
2 participants