Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Declare ci_run flag in build.rs #1071

Merged
merged 1 commit into from
May 17, 2024
Merged

chore: Declare ci_run flag in build.rs #1071

merged 1 commit into from
May 17, 2024

Conversation

aborgna-q
Copy link
Collaborator

Rust 1.80 will require pre-declaring configuration flags that we want to set via RUSTFLAGS.
See the blog post.

Fixes #1067.

@aborgna-q aborgna-q requested a review from a team as a code owner May 17, 2024 10:50
@aborgna-q aborgna-q requested a review from doug-q May 17, 2024 10:50
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (cc7f067) to head (96821bc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1071      +/-   ##
==========================================
- Coverage   86.59%   86.55%   -0.04%     
==========================================
  Files          83       83              
  Lines       17547    17547              
  Branches    17547    17547              
==========================================
- Hits        15194    15188       -6     
- Misses       1533     1539       +6     
  Partials      820      820              
Flag Coverage Δ
rust 86.55% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicted on whether to be Glad or Sad about a build.rs...

@croyzor
Copy link
Contributor

croyzor commented May 17, 2024

Can't this be defined in a Cargo.toml file?

@aborgna-q
Copy link
Collaborator Author

From the blogpost:

There is currently no way to expect a custom cfg other than with cargo::rustc-check-cfg in a build.rs.

Hopefully they add the option at some point

@aborgna-q aborgna-q added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 4d974cf May 17, 2024
17 checks passed
@aborgna-q aborgna-q deleted the ab/build-script branch May 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deal with "unexpected cfg condition name: ci_run
3 participants