Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try adding FunctionTypeVarArgs #1062

Closed
wants to merge 45 commits into from
Closed

try adding FunctionTypeVarArgs #1062

wants to merge 45 commits into from

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented May 16, 2024

A bunch of renames should happen, which I have omitted to reduce the diff. In order:

  • rename FunctionType::new to new_unchecked
  • make the members of FunctionType private
  • Invert the newtyping of FunctionType and FunctionTypeVarArgs
  • rename FunctionType to Signature
  • rename FunctionTypeVarArgs to FunctionType

@doug-q doug-q closed this May 16, 2024
@doug-q doug-q reopened this May 16, 2024
@doug-q doug-q marked this pull request as draft May 16, 2024 06:49
@doug-q doug-q requested a review from acl-cqc May 16, 2024 06:49
Base automatically changed from feat/row_typevar to main May 22, 2024 09:33
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Your title should look like this. The scope field is optional.

<type>(<scope>): <description>

If the PR includes a breaking change, mark it with an exclamation mark:

<type>!: <description>

and include a "BREAKING CHANGE:" footer in the body of the pull request.

Details:

No release type found in pull request title "try adding FunctionTypeVarArgs". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - ci
 - chore
 - revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants