-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add devenv option to not install git hooks #1015
Conversation
Please feel free to improve my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence on whether we should run poetry install
directly in the devenv config, instead of adding complexity to the justfile.
- Is there any usecase where we'd run
just install false
manually? The parameter gets confusing there. - Is it easy to do
poetry install
conditionally on the devenv.nix config?
To be clear we are talking about a flag
Yes, I would do this every time. it's
Yes, I think this is the best option To be clear, I can disable git hooks in my local repo so it's not the biggest deal. |
We could have a install:
poetry install recipe for the non-hooks variant, but that's just renaming things without adding much functionality. |
240abf7
to
559bcf2
Compare
559bcf2
to
9ac53ef
Compare
I think we agree on I don't think you'll like the justfile changes, but I'm trying my luck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer it to the parameter version. Let's go with this 👍
Tested with and without a
devenv.local.nix
with