Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Run validation before extension inference #1008

Closed
wants to merge 3 commits into from

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented May 8, 2024

Resolves #943

@croyzor croyzor requested a review from acl-cqc May 8, 2024 09:10
@croyzor croyzor changed the title new: Run validation before extension inference refactor: Run validation before extension inference May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (4409d1d) to head (5f0039c).

❗ Current head 5f0039c differs from pull request most recent head 035a44d. Consider uploading reports for the commit 035a44d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
+ Coverage   85.73%   85.80%   +0.06%     
==========================================
  Files          79       79              
  Lines       14607    14621      +14     
  Branches    14607    14621      +14     
==========================================
+ Hits        12524    12546      +22     
+ Misses       1427     1418       -9     
- Partials      656      657       +1     
Flag Coverage Δ
rust 85.80% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@croyzor
Copy link
Contributor Author

croyzor commented May 8, 2024

Superceded by #1011

@croyzor croyzor closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Validate hugrs before extension inference is run
1 participant