Skip to content

Commit

Permalink
test: ignore serialisation tests when using miri (#975)
Browse files Browse the repository at this point in the history
Fixes #969.

This solution is an over approximation because many serialisation
tests(in which I include comprehensive coverage which does not yet
exist) would not trigger the problem. This would be easy to remove if
miri grows support. The most recent activity on the ticket is positive.
  • Loading branch information
doug-q authored Apr 26, 2024
1 parent 529f553 commit ef5485a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions hugr/src/hugr/serialize.rs
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,9 @@ impl TryFrom<SerHugrV1> for Hugr {
}

#[cfg(test)]
#[cfg_attr(miri, ignore = "miri does not support 'life before main'")]
// Miri doesn't run the extension registration required by `typetag` for
// registering `CustomConst`s. https://github.com/rust-lang/miri/issues/450
pub mod test {

use super::*;
Expand Down Expand Up @@ -547,9 +550,6 @@ pub mod test {
}

#[test]
#[cfg_attr(miri, ignore = "Extension ops cannot be used with miri.")]
// Miri doesn't run the extension registration required by `typetag` for registering `CustomConst`s.
// https://github.com/rust-lang/miri/issues/450
fn constants_roundtrip() -> Result<(), Box<dyn std::error::Error>> {
let mut builder = DFGBuilder::new(FunctionType::new(vec![], vec![FLOAT64_TYPE])).unwrap();
let w = builder.add_load_value(ConstF64::new(0.5));
Expand Down
1 change: 1 addition & 0 deletions hugr/src/hugr/validate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ impl<'a, 'b> ValidationContext<'a, 'b> {
// in-tree schema. For now, our serialized hugr does not match the
// schema. When this is fixed we should pass true below.
#[cfg(test)]
#[cfg_attr(miri, ignore = "miri does not support 'life before main'")]
crate::hugr::serialize::test::check_hugr_roundtrip(self.hugr, false);

Ok(())
Expand Down

0 comments on commit ef5485a

Please sign in to comment.