refactor: rename accidentally-changed Extension::add_node_xxx back to…

… add_op (#659)

Ooops, these were accidentally hit by renaming in #642 .

Driveby: change a couple of `add_op_custom_sig`'s in extension.rs to use
the `custom_sig_simple` variant

src/extension/op_def.rs

@@ -270,7 +270,7 @@ impl Extension {
     }
 
     /// Create an OpDef with custom binary code to compute the signature
-    pub fn add_node_custom_sig(
+    pub fn add_op_custom_sig(
         &mut self,
         name: SmolStr,
         description: String,
@@ -291,14 +291,14 @@ impl Extension {
 
     /// Create an OpDef with custom binary code to compute the signature, and no "misc" or "lowering
     /// functions" defined.
-    pub fn add_node_custom_sig_simple(
+    pub fn add_op_custom_sig_simple(
         &mut self,
         name: SmolStr,
         description: String,
         params: Vec<TypeParam>,
         signature_func: impl CustomSignatureFunc + 'static,
     ) -> Result<&OpDef, ExtensionBuildError> {
-        self.add_node_custom_sig(
+        self.add_op_custom_sig(
             name,
             description,
             params,
@@ -310,7 +310,7 @@ impl Extension {
 
     /// Create an OpDef with a signature (inputs+outputs) read from the
     /// declarative YAML
-    pub fn add_node_decl_sig(
+    pub fn add_op_decl_sig(
         &mut self,
         name: SmolStr,
         description: String,

src/extension/prelude.rs

@@ -41,7 +41,7 @@ lazy_static! {
             .unwrap();
 
         prelude
-            .add_node_custom_sig_simple(
+            .add_op_custom_sig_simple(
                 SmolStr::new_inline(NEW_ARRAY_OP_ID),
                 "Create a new array from elements".to_string(),
                 vec![TypeParam::Type(TypeBound::Any), TypeParam::max_nat()],

src/std_extensions/arithmetic/conversions.rs

@@ -44,31 +44,31 @@ pub fn extension() -> Extension {
     );
 
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "trunc_u".into(),
             "float to unsigned int".to_owned(),
             vec![LOG_WIDTH_TYPE_PARAM],
             ftoi_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "trunc_s".into(),
             "float to signed int".to_owned(),
             vec![LOG_WIDTH_TYPE_PARAM],
             ftoi_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "convert_u".into(),
             "unsigned int to float".to_owned(),
             vec![LOG_WIDTH_TYPE_PARAM],
             itof_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "convert_s".into(),
             "signed int to float".to_owned(),
             vec![LOG_WIDTH_TYPE_PARAM],

src/std_extensions/arithmetic/float_ops.rs

@@ -41,77 +41,77 @@ pub fn extension() -> Extension {
     );
 
     extension
-        .add_node_custom_sig_simple("feq".into(), "equality test".to_owned(), vec![], fcmp_sig)
+        .add_op_custom_sig_simple("feq".into(), "equality test".to_owned(), vec![], fcmp_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fne".into(), "inequality test".to_owned(), vec![], fcmp_sig)
+        .add_op_custom_sig_simple("fne".into(), "inequality test".to_owned(), vec![], fcmp_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("flt".into(), "\"less than\"".to_owned(), vec![], fcmp_sig)
+        .add_op_custom_sig_simple("flt".into(), "\"less than\"".to_owned(), vec![], fcmp_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "fgt".into(),
             "\"greater than\"".to_owned(),
             vec![],
             fcmp_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "fle".into(),
             "\"less than or equal\"".to_owned(),
             vec![],
             fcmp_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "fge".into(),
             "\"greater than or equal\"".to_owned(),
             vec![],
             fcmp_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fmax".into(), "maximum".to_owned(), vec![], fbinop_sig)
+        .add_op_custom_sig_simple("fmax".into(), "maximum".to_owned(), vec![], fbinop_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fmin".into(), "minimum".to_owned(), vec![], fbinop_sig)
+        .add_op_custom_sig_simple("fmin".into(), "minimum".to_owned(), vec![], fbinop_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fadd".into(), "addition".to_owned(), vec![], fbinop_sig)
+        .add_op_custom_sig_simple("fadd".into(), "addition".to_owned(), vec![], fbinop_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fsub".into(), "subtraction".to_owned(), vec![], fbinop_sig)
+        .add_op_custom_sig_simple("fsub".into(), "subtraction".to_owned(), vec![], fbinop_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fneg".into(), "negation".to_owned(), vec![], funop_sig)
+        .add_op_custom_sig_simple("fneg".into(), "negation".to_owned(), vec![], funop_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "fabs".into(),
             "absolute value".to_owned(),
             vec![],
             funop_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple(
+        .add_op_custom_sig_simple(
             "fmul".into(),
             "multiplication".to_owned(),
             vec![],
             fbinop_sig,
         )
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fdiv".into(), "division".to_owned(), vec![], fbinop_sig)
+        .add_op_custom_sig_simple("fdiv".into(), "division".to_owned(), vec![], fbinop_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("ffloor".into(), "floor".to_owned(), vec![], funop_sig)
+        .add_op_custom_sig_simple("ffloor".into(), "floor".to_owned(), vec![], funop_sig)
         .unwrap();
     extension
-        .add_node_custom_sig_simple("fceil".into(), "ceiling".to_owned(), vec![], funop_sig)
+        .add_op_custom_sig_simple("fceil".into(), "ceiling".to_owned(), vec![], funop_sig)
         .unwrap();
 
     extension