Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to poetry for build system #88

Merged
merged 3 commits into from
Jan 11, 2024
Merged

chore: switch to poetry for build system #88

merged 3 commits into from
Jan 11, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jan 10, 2024 •
edited
Loading

mypy version bump from 1.3 -> 1.8 caused some type fixes

@ss2165 ss2165 requested a review from mark-koch January 10, 2024 16:37
@aborgna-q aborgna-q mentioned this pull request Jan 10, 2024
Open
@ss2165 ss2165 removed the request for review from mark-koch January 10, 2024 17:19
@ss2165 ss2165 assigned aborgna-q and unassigned aborgna-q Jan 10, 2024
@ss2165 ss2165 requested a review from aborgna-q January 10, 2024 17:19
aborgna-q
aborgna-q approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ss2165 ss2165 merged commit e17ac31 into main Jan 11, 2024
1 check passed
@ss2165 ss2165 deleted the chore/poetry branch January 11, 2024 09:17
@qartik qartik mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborgna-q aborgna-q aborgna-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ss2165 @aborgna-q