-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add string type #733
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
156dd8f
Add strings type (without value)
tatiana-s c3435b4
Merge remote-tracking branch 'origin/main' into ts/strings
tatiana-s 14c5446
Add hugr string val
tatiana-s 60e17be
Change branch to rev
tatiana-s 01c2d1a
Add py test
tatiana-s 996f9ea
Merge remote-tracking branch 'origin/main' into ts/strings
tatiana-s b809414
Change unsupported constant example
tatiana-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
Error: Unsupported constant (at $FILE:7:8) | ||
Error: Unsupported constant (at $FILE:6:9) | ||
| | ||
5 | @compile_guppy | ||
6 | def foo() -> None: | ||
7 | x = "foo" | ||
| ^^^^^ Type `str` is not supported | ||
4 | @compile_guppy | ||
5 | def foo() -> None: | ||
6 | x = -2j | ||
| ^^ Type `complex` is not supported | ||
|
||
Guppy compilation failed due to 1 previous error |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
from guppylang.std.builtins import array | ||
from tests.util import compile_guppy | ||
|
||
|
||
@compile_guppy | ||
def foo() -> None: | ||
x = "foo" | ||
x = -2j |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
from guppylang.decorator import guppy | ||
from guppylang.module import GuppyModule | ||
from tests.util import compile_guppy | ||
|
||
import pytest | ||
|
||
def test_basic_type(validate): | ||
@compile_guppy | ||
def foo(x: str) -> str: | ||
return x | ||
|
||
validate(foo) | ||
|
||
|
||
def test_basic_value(validate): | ||
@compile_guppy | ||
def foo() -> str: | ||
x = "Hello World" | ||
return x | ||
|
||
validate(foo) | ||
|
||
|
||
def test_struct(validate): | ||
module = GuppyModule("module") | ||
|
||
@guppy.struct(module) | ||
class StringStruct: | ||
x: str | ||
|
||
@guppy(module) | ||
def main(s: StringStruct) -> None: | ||
StringStruct("Lorem Ipsum") | ||
|
||
validate(module.compile()) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create guppy strings from
py(...)
expressions? I'd like a test of that as well please!