chore: Define arithmetic methods via Guppy source instead of custom compilers #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
force-pushed
the
chore/arith-source
branch
from
41397fd to
49b6095
Compare
mark-koch
commented
Dec 10, 2024
Comment on lines
+109
to
+110
| # TODO: Literals should check against `nat` | ||
| return nat(1) if self else nat(0) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/coerce #703 +/- ##
===============================================
- Coverage 92.72% 92.60% -0.13%
===============================================
Files 71 71
Lines 7921 7872 -49
===============================================
- Hits 7345 7290 -55
- Misses 576 582 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #464.
Removes the
CoercingCheckerfollowing #702. Also refactorsReversingCheckerto figure out the unreversed method by itself.