style: add pre-commit, typos and ruff, fix several #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
commented
Dec 5, 2023
| - id: end-of-file-fixer | ||
| - id: fix-byte-order-marker | ||
| - id: mixed-line-ending | ||
| # - id: trailing-whitespace |
There was a problem hiding this comment.
Doesn't work well with .err files.
qartik
commented
Dec 5, 2023
qartik
commented
Dec 5, 2023
qartik
commented
Dec 5, 2023
qartik
commented
Dec 5, 2023
| ignore = [ | ||
| "COM812", "ISC001", # conflicting with the formatter | ||
| "S101", # Use of `assert` detected | ||
| "B905", # `zip()` without an explicit `strict=` parameter |
There was a problem hiding this comment.
This last lint could probably be fixed and removed from ignore. I didn't want to assume.
There was a problem hiding this comment.
From memory it should be fine to add strict=True to every zip, but should check to make sure. I added an issue #65 for this
qartik
commented
Dec 5, 2023
| "T10", # flake8-debugger | ||
| "T20", # flake8-print | ||
| "TCH", # flake8-type-checking | ||
| # "TD", # flake8-todos |
There was a problem hiding this comment.
Many of these commented out lints can be enabled if desired.
qartik
changed the title
mark-koch
reviewed
Dec 6, 2023
| ignore = [ | ||
| "COM812", "ISC001", # conflicting with the formatter | ||
| "S101", # Use of `assert` detected | ||
| "B905", # `zip()` without an explicit `strict=` parameter |
There was a problem hiding this comment.
From memory it should be fine to add strict=True to every zip, but should check to make sure. I added an issue #65 for this
qartik
commented
Dec 7, 2023
mark-koch
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff.tomlwith some sane lints, with some disabledMANIFEST.inrequirements.txtFixes #63