chore: Add Ruff linting #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
requested changes
Nov 6, 2023
.github/workflows/pull-request.yaml
Outdated
Comment on lines
40
to
44
| - name: Check formatting with ruff | ||
| run: ruff format --check guppy | ||
|
|
||
| - name: Lint with ruff | ||
| run: ruff check guppy |
There was a problem hiding this comment.
Better to use ruff_action instead, see example:
There was a problem hiding this comment.
Done. Just wondering, why is this better than just invoking the cli?
There was a problem hiding this comment.
mainly future-proofing and version control https://github.com/chartboost/ruff-action
ss2165
approved these changes
Nov 6, 2023
|
You may also want to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54