[new] Wire up the remaining integration tests for export #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
reviewed
Sep 27, 2023
tests/integration/test_call.py
Outdated
Comment on lines
19
to
18
| def test_call_back(tmp_path): | ||
| def test_call_back(tmp_path, validate): |
There was a problem hiding this comment.
Oh, this tmp_path fixture actually shouldn't be here! Maybe we can remove it as a drive-by?
doug-q
force-pushed
the
new/export-all-integration-tests
branch
from
1714665 to
aec1216
Compare
mark-koch
approved these changes
Sep 27, 2023
| @@ -94,8 +93,9 @@ def main(x: int, y: int) -> None: | |||
| uncurried(x, y) | |||
| curry(uncurry(curry(gt)))(y)(x) | |||
|
|
|||
| validate(module.compile()) | |||
tests/integration/test_programs.py
Outdated
| @@ -2,7 +2,7 @@ | |||
| from tests.integration.util import validate, functional, _ | |||
There was a problem hiding this comment.
Can the validate import be removed here? Also, if it's generally no longer used, we could just remove it from util
Edit: Same in test_unused.py
tests/integration/test_call.py
Outdated
Comment on lines
19
to
18
| def test_call_back(tmp_path): | ||
| def test_call_back(tmp_path, validate): |
We also fix the ycombinator test case
doug-q
force-pushed
the
new/export-all-integration-tests
branch
from
aec1216 to
dcf0fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also fix the ycombinator test case