feat: Add a unified definition system #179
Conversation
| @@ -0,0 +1,116 @@ | |||
| import ast | |||
There was a problem hiding this comment.
This is the main file laying out the compilation fow for definitions
guppylang/definition/declaration.py
Outdated
There was a problem hiding this comment.
This file was mostly copied from the old guppylang/declared.py
There was a problem hiding this comment.
This file was mostly copied from guppylang/checker/func_checker.py and guppylang/compiler/func_compiler.py
guppylang/definition/value.py
Outdated
There was a problem hiding this comment.
This file was mostly copied from guppylang/checker/core.py and guppylang/compiler/core.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 90.55% 90.67% +0.11%
==========================================
Files 41 46 +5
Lines 4595 4717 +122
==========================================
+ Hits 4161 4277 +116
- Misses 434 440 +6 ☔ View full report in Codecov by Sentry. |
guppylang/prelude/builtins.py
Outdated
There was a problem hiding this comment.
Here, we replace the old bool(x), int(x) etc functions with a __new__(x) constructor
| return with_loc(node, GlobalName(id=x, def_id=defn.id)), defn.ty | ||
| # For types, we return their `__new__` constructor | ||
| case TypeDef() as defn if constr := self.ctx.globals.get_instance_func( | ||
| defn, "__new__" |
There was a problem hiding this comment.
So for Qubit, this is doing a QAlloc whenever we find a name? I'm not 100% sure when I should expect to find Names that stand for types here. The obvious example is x = Qubit() - I hope everything else is covered by stmt_checker.py (like AnnAssign and type signatures on functions)
There was a problem hiding this comment.
There is also int(x) which takes everthing that implements __int__, same for float(x) and bool(x).
Before, these were defined as functions, but now the names is already taken by the type.
Python handles this in the same way: int is a class/type and "calling" a class executes the constructor
There was a problem hiding this comment.
Sure, but I'm only worried about the Qubit case because adding unnecessary QAllocs (when checking type signatrues for example) will mess up any qubit resource estimates!
However, I'm fairly satisfied we're doing the right thing here
There was a problem hiding this comment.
Ah I see. Yes, Name nodes in types are handled by different code in tys.parsing
DefinitionABC for all user-defined things on module-level. Currently, these are functions, types, and type vars.guppylang.definitionGlobalscontainer is restructured accordingly.int(x),bool(x),qubit(), etc. functions are replaced with calls to the__new__constructor of the type.ParsableDef -> CheckableDef -> CompilableDef -> CompiledDefRawDef < ParsedDef < CheckedDef < CompiledDefCloses #175 and also closes #170 (as a drive-by)