Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop exiting interpreter on error #140

Merged
merged 2 commits into from
Feb 1, 2024
Merged

fix: Stop exiting interpreter on error #140

merged 2 commits into from
Feb 1, 2024

Conversation

mark-koch
Copy link
Collaborator

Instead, let the exception go through and use sys.excepthook to customise how the error message is printed.

Fixes #109

@mark-koch mark-koch requested a review from ss2165 January 25, 2024 15:13
Comment on lines 215 to 216
if "pytest" in sys.modules:
hook(type(err), err, err.__traceback__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-koch mark-koch requested a review from ss2165 January 30, 2024 09:19
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@mark-koch mark-koch merged commit 728e449 into main Feb 1, 2024
2 checks passed
@mark-koch mark-koch deleted the fix/exit branch February 1, 2024 09:56
This was referenced Apr 10, 2024
mark-koch added a commit that referenced this pull request Apr 11, 2024
🤖 I have created a release *beep* *boop*
---


## 0.2.0 (2024-04-11)


### ⚠ BREAKING CHANGES

* Make `qubit` type lower case
([#165](#165))

### Features

* Local implicit modules for `@guppy`
([#105](#105))
([f52a5de](f52a5de))
* New type representation with parameters
([#174](#174))
([73e29f2](73e29f2))


### Bug Fixes

* Make ZZMax a dyadic operation
([#168](#168))
([152485f](152485f)),
closes [#154](#154)
* Stop exiting interpreter on error
([#140](#140))
([728e449](728e449))
* Use correct TK2 gate names
([#190](#190))
([df92642](df92642))


### Documentation

* add reference to runner to readme
([#129](#129))
([45c2bf0](45c2bf0))
* Add short description and simplify readme for pypi
([#136](#136))
([667bba3](667bba3))


### Code Refactoring

* Make `qubit` type lower case
([#165](#165))
([0a42097](0a42097))


### Continuous Integration

* Use `release-please bootstrap`'s default config
([#187](#187))
([72e666a](72e666a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mark Koch <[email protected]>
croyzor pushed a commit that referenced this pull request Apr 16, 2024
🤖 I have created a release *beep* *boop*
---


## 0.2.0 (2024-04-11)


### ⚠ BREAKING CHANGES

* Make `qubit` type lower case
([#165](#165))

### Features

* Local implicit modules for `@guppy`
([#105](#105))
([f52a5de](f52a5de))
* New type representation with parameters
([#174](#174))
([73e29f2](73e29f2))


### Bug Fixes

* Make ZZMax a dyadic operation
([#168](#168))
([152485f](152485f)),
closes [#154](#154)
* Stop exiting interpreter on error
([#140](#140))
([728e449](728e449))
* Use correct TK2 gate names
([#190](#190))
([df92642](df92642))


### Documentation

* add reference to runner to readme
([#129](#129))
([45c2bf0](45c2bf0))
* Add short description and simplify readme for pypi
([#136](#136))
([667bba3](667bba3))


### Code Refactoring

* Make `qubit` type lower case
([#165](#165))
([0a42097](0a42097))


### Continuous Integration

* Use `release-please bootstrap`'s default config
([#187](#187))
([72e666a](72e666a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mark Koch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't exit python interpreter on compiler error (kills kernel).
2 participants