-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Stop exiting interpreter on error #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
reviewed
Jan 29, 2024
guppylang/error.py
Outdated
Comment on lines
215
to
216
if "pytest" in sys.modules: | ||
hook(type(err), err, err.__traceback__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.pytest.org/en/latest/example/simple.html#pytest-current-test-environment-variable
this seems like a more stable test?
ss2165
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 👍
This was referenced Apr 10, 2024
mark-koch
added a commit
that referenced
this pull request
Apr 11, 2024
🤖 I have created a release *beep* *boop* --- ## 0.2.0 (2024-04-11) ### ⚠ BREAKING CHANGES * Make `qubit` type lower case ([#165](#165)) ### Features * Local implicit modules for `@guppy` ([#105](#105)) ([f52a5de](f52a5de)) * New type representation with parameters ([#174](#174)) ([73e29f2](73e29f2)) ### Bug Fixes * Make ZZMax a dyadic operation ([#168](#168)) ([152485f](152485f)), closes [#154](#154) * Stop exiting interpreter on error ([#140](#140)) ([728e449](728e449)) * Use correct TK2 gate names ([#190](#190)) ([df92642](df92642)) ### Documentation * add reference to runner to readme ([#129](#129)) ([45c2bf0](45c2bf0)) * Add short description and simplify readme for pypi ([#136](#136)) ([667bba3](667bba3)) ### Code Refactoring * Make `qubit` type lower case ([#165](#165)) ([0a42097](0a42097)) ### Continuous Integration * Use `release-please bootstrap`'s default config ([#187](#187)) ([72e666a](72e666a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mark Koch <[email protected]>
croyzor
pushed a commit
that referenced
this pull request
Apr 16, 2024
🤖 I have created a release *beep* *boop* --- ## 0.2.0 (2024-04-11) ### ⚠ BREAKING CHANGES * Make `qubit` type lower case ([#165](#165)) ### Features * Local implicit modules for `@guppy` ([#105](#105)) ([f52a5de](f52a5de)) * New type representation with parameters ([#174](#174)) ([73e29f2](73e29f2)) ### Bug Fixes * Make ZZMax a dyadic operation ([#168](#168)) ([152485f](152485f)), closes [#154](#154) * Stop exiting interpreter on error ([#140](#140)) ([728e449](728e449)) * Use correct TK2 gate names ([#190](#190)) ([df92642](df92642)) ### Documentation * add reference to runner to readme ([#129](#129)) ([45c2bf0](45c2bf0)) * Add short description and simplify readme for pypi ([#136](#136)) ([667bba3](667bba3)) ### Code Refactoring * Make `qubit` type lower case ([#165](#165)) ([0a42097](0a42097)) ### Continuous Integration * Use `release-please bootstrap`'s default config ([#187](#187)) ([72e666a](72e666a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mark Koch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, let the exception go through and use
sys.excepthook
to customise how the error message is printed.Fixes #109