Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix pre-commit config, fix linting #116

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

The mypy step in pre-commit didn't get updated after the name change.

pre-commit run --all-files threw multiple errors, so I updated those too.
(I had to update the mypy check version to avoid some missing type errors).

@aborgna-q aborgna-q requested a review from mark-koch January 18, 2024 17:17
@aborgna-q aborgna-q force-pushed the fix/pre-commit-config branch from 4f9763c to d0f7b6e Compare January 18, 2024 17:37
@qartik
Copy link
Member

qartik commented Jan 19, 2024

I see that mypy and ruff are being run on the CI, but it might be nice to just run this pre-commit config there instead of separate checks.

Also, I noticed poetry install doesn't seem to install some necessary dependencies such as pytest, pytket and tket2. We should document those in the README under developer instructions. I am new to poetry, I wonder if it allows additional deps analogous to pip install .[dev] that we did before.

@aborgna-q
Copy link
Collaborator Author

There's a [tool.poetry.group.dev.dependencies] section for dev dependencies.

I think #118 adds tket2 as an optional dep. You need to pass --extras=pytket to poetry to install them.

@ss2165
Copy link
Member

ss2165 commented Jan 19, 2024

poetry install should install everything in the dev dependency group - CI relies on this.

We will add details about how to use all these extra dependencies with poetry in the README in a follow up PR

@aborgna-q aborgna-q requested a review from ss2165 January 19, 2024 13:08
@ss2165 ss2165 merged commit 4e0fb58 into main Jan 24, 2024
1 check passed
@ss2165 ss2165 deleted the fix/pre-commit-config branch January 24, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants