feat!: Add remaining tket2 ops #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
commented
Jan 16, 2024
guppy/prelude/quantum.py
Outdated
Comment on lines
83
to
85
| @guppy.hugr_op(quantum, quantum_op("Measure")) | ||
| def measure_q(q: Qubit) -> tuple[Qubit, bool]: | ||
| ... |
There was a problem hiding this comment.
Any ideas for a better name?
There was a problem hiding this comment.
restless_measure or nondestructive_measure ?
There was a problem hiding this comment.
Seyon suggested measure_return?
mark-koch
commented
Jan 16, 2024
guppy/prelude/quantum.py
Outdated
Comment on lines
128
to
130
| @guppy.custom(quantum, MeasureCompiler()) | ||
| def measure(q: Qubit) -> bool: | ||
| ... |
There was a problem hiding this comment.
Ideally, we would directly write
@guppy(quantum)
def measure(q: Qubit) -> bool:
q, res = measure_q(q)
discrad(q)
return resHowever, linking doesn't work yet, so we have to use a CustomCallCompiler
aborgna-q
approved these changes
Jan 16, 2024
guppy/prelude/quantum.py
Outdated
Comment on lines
83
to
85
| @guppy.hugr_op(quantum, quantum_op("Measure")) | ||
| def measure_q(q: Qubit) -> tuple[Qubit, bool]: | ||
| ... |
There was a problem hiding this comment.
restless_measure or nondestructive_measure ?
mark-koch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the signature of
measuretoQubit -> bool.Fixes #104 and fixes #106