Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't exit python interpreter on compiler error (kills kernel). #109

Closed
ss2165 opened this issue Jan 17, 2024 · 2 comments · Fixed by #140
Closed

Don't exit python interpreter on compiler error (kills kernel). #109

ss2165 opened this issue Jan 17, 2024 · 2 comments · Fixed by #140
Assignees
@mark-koch
Labels
bug Something isn't working

Comments

@ss2165
Copy link
Member

ss2165 commented Jan 17, 2024

or make it easy to configure
@ss2165 ss2165 added the bug Something isn't working label Jan 17, 2024
@mark-koch
Copy link
Collaborator

What's the preferred way to configure this?

  • Environment variable?
  • Optional argument of compile()?
  • Constant flag in the source code?
  • Other ideas?

@ss2165
Copy link
Member Author

ss2165 commented Jan 18, 2024 •
edited
Loading

Not keen on environment variables - I would suggest make it optional to compile, set the default to just raising the error normally, then any CLI/complete file handling code can internally choose to set it to printing and exiting

@mark-koch mark-koch mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-koch mark-koch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Stop exiting interpreter on error CQCL/guppylang
2 participants
@ss2165 @mark-koch