Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow brackets in abstractors #53

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

croyzor
Copy link
Collaborator

@croyzor croyzor commented Nov 6, 2024

Based on #68

croyzor and others added 8 commits December 17, 2024 15:29
This is targetted at #68.

After some preliminary refactorings to remove `Bwd` in #72, I realized
`brackets` and `within` were 90% the same, but resisted my first
attempts to combine them ;). Changing the contract on `within` (here
renamed `helper` and made local to `brackets`) allowed this to proceed.

Note the second commit makes explicit, using `Maybe....NonEmpty` an
invariant that in the first commit is just comments and
incomplete-pattern-matches; you may prefer the first way though.

---------

Co-authored-by: Craig Roy <[email protected]>
Base automatically changed from refactor/parser-wc to main December 23, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants